Commit 9e0658637ee7c380e2c2e35cdbcf66e92ca03f4b
1 parent
48a57a14
Revert "Revert "more thread syncs.""
This reverts commit 48a57a14.
Showing
13 changed files
with
102 additions
and
32 deletions
... | ... | @@ -52,7 +52,8 @@ TR_CLASS(TR_EventDispatcher) { |
52 | 52 | TR_Queue events; |
53 | 53 | pthread_mutex_t events_lock; |
54 | 54 | pthread_cond_t events_cond; |
55 | - pthread_t events_wait; | |
55 | + pthread_t events_poll; | |
56 | + size_t events_handling; | |
56 | 57 | |
57 | 58 | TR_Hash handler; |
58 | 59 | TR_EventHandler default_handler; | ... | ... |
... | ... | @@ -24,6 +24,7 @@ |
24 | 24 | #define __TR_EVENT_HANDLER_H__ |
25 | 25 | |
26 | 26 | #include <sys/types.h> |
27 | +#include <pthread.h> | |
27 | 28 | |
28 | 29 | #include "trbase.h" |
29 | 30 | #include "trdata.h" |
... | ... | @@ -68,6 +69,12 @@ void TR__eventHandlerClassCleanup(TR_class_ptr); |
68 | 69 | sizeof(TR_EventMethod_fptr))); \ |
69 | 70 | } while(0) |
70 | 71 | |
72 | +#define TR_INIT_HANDLER(cname) \ | |
73 | + TR_INSTANCE(TR_Tree, cname##EventMethodsTree, NULL, PTHREAD_MUTEX_INITIALIZER); \ | |
74 | + TR_INSTANCE(TR_Hash, cname##EventMethods, &(_##cname##EventMethodsTree.data), 0) | |
75 | + | |
76 | +#define TR_HANDLER_CVARS(cname) &(_##cname##EventMethods.data) | |
77 | + | |
71 | 78 | #endif // __TR_EVENT_HANDLER_H__ |
72 | 79 | |
73 | 80 | // vim: set ts=4 sw=4: | ... | ... |
... | ... | @@ -25,12 +25,14 @@ |
25 | 25 | |
26 | 26 | #include <sys/types.h> |
27 | 27 | #include <stdint.h> |
28 | +#include <pthread.h> | |
28 | 29 | |
29 | 30 | #include "trbase.h" |
30 | 31 | |
31 | 32 | TR_CLASS(TR_EventSubject) { |
32 | - int fin; | |
33 | - size_t emitted; | |
33 | + int fin; | |
34 | + size_t emitted; | |
35 | + pthread_mutex_t lock; | |
34 | 36 | }; |
35 | 37 | TR_INSTANCE_INIT(TR_EventSubject); |
36 | 38 | TR_CLASSVARS_DECL(TR_EventSubject) { |
... | ... | @@ -57,6 +59,16 @@ TR_CLASSVARS_DECL(TR_EventSubject) { |
57 | 59 | intptr_t TR__eventSubjectId(TR_class_ptr, size_t); |
58 | 60 | TR_Event TR_eventSubjectEmit(TR_EventSubject, int, void *); |
59 | 61 | |
62 | +static | |
63 | +inline | |
64 | +void | |
65 | +TR_eventSubjectAbsorb(TR_EventSubject this) | |
66 | +{ | |
67 | + pthread_mutex_lock(&this->lock); | |
68 | + this->emitted = this->emitted == 0 ? 0 : this->emitted - 1; | |
69 | + pthread_mutex_unlock(&this->lock); | |
70 | +} | |
71 | + | |
60 | 72 | #define TR_eventSubjectFinalize(es) ((es)->fin = TRUE) |
61 | 73 | |
62 | 74 | #endif // __TR_EVENT_SUBJECT_H__ | ... | ... |
... | ... | @@ -29,8 +29,9 @@ |
29 | 29 | #include "event_dispatcher.h" |
30 | 30 | |
31 | 31 | TR_CLASS(TR_EventThread) { |
32 | - TR_EventDispatcher dispatcher; | |
33 | - pthread_t handle; | |
32 | + TR_EventDispatcher dispatcher; | |
33 | + pthread_t handle; | |
34 | + char * name; | |
34 | 35 | }; |
35 | 36 | TR_INSTANCE_INIT(TR_EventThread); |
36 | 37 | TR_CLASSVARS_DECL(TR_EventThread) {}; | ... | ... |
... | ... | @@ -41,13 +41,13 @@ eventCtor(void * _this, va_list * params) |
41 | 41 | return 0; |
42 | 42 | } |
43 | 43 | |
44 | -static void eventDtor(void * _this) | |
44 | +static | |
45 | +void | |
46 | +eventDtor(void * _this) | |
45 | 47 | { |
46 | 48 | TR_Event this = _this; |
47 | 49 | |
48 | - this->subject->emitted = | |
49 | - this->subject->emitted == 0 | |
50 | - ? 0 : this->subject->emitted - 1; | |
50 | + TR_eventSubjectAbsorb(this->subject); | |
51 | 51 | |
52 | 52 | if (0 == this->subject->emitted && this->subject->fin) { |
53 | 53 | TR_delete(this->subject); | ... | ... |
... | ... | @@ -20,6 +20,8 @@ |
20 | 20 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
21 | 21 | */ |
22 | 22 | |
23 | +#define _GNU_SOURCE | |
24 | + | |
23 | 25 | #include "trbase.h" |
24 | 26 | #include "trdata.h" |
25 | 27 | #include "trhash.h" |
... | ... | @@ -49,28 +51,39 @@ TR_eventDispatcherStart(TR_EventDispatcher this) |
49 | 51 | (TR_EventSubject)this, |
50 | 52 | TR_DISPATCHER_EVENT_HEARTBEAT, |
51 | 53 | NULL); |
52 | - } else if (TR_queueEmpty(this->events)) { | |
53 | - if (! this->events_wait) { | |
54 | + } else { | |
55 | + event = TR_queueGet(this->events); | |
56 | + | |
57 | + if (! (event || this->events_poll || this->events_handling)) { | |
54 | 58 | int evtid = TR_EVD_CLIENT == this->mode |
55 | 59 | ? TR_DISPATCHER_EVENT_USER_WAIT |
56 | 60 | : TR_DISPATCHER_EVENT_DATA_WAIT; |
57 | 61 | |
58 | - this->events_wait = pthread_self(); | |
62 | + this->events_poll = pthread_self(); | |
59 | 63 | event = TR_eventSubjectEmit((TR_EventSubject)this, evtid, NULL); |
60 | - } else { | |
61 | - pthread_cond_wait(&(this->events_cond), &(this->events_lock)); | |
62 | - event = NULL; | |
63 | 64 | } |
64 | - } else { | |
65 | - event = TR_queueGet(this->events); | |
66 | 65 | } |
67 | 66 | |
68 | - pthread_mutex_unlock(&(this->events_lock)); | |
69 | - | |
70 | 67 | if (! event) { |
68 | + char buffer[17]; | |
69 | + | |
70 | + pthread_getname_np(pthread_self(), buffer, 17); | |
71 | + TR_loggerLog(TR_logger, TR_LOGGER_DEBUG, | |
72 | + "[%s] - enter cond wait", | |
73 | + buffer); | |
74 | + pthread_cond_wait(&(this->events_cond), &(this->events_lock)); | |
75 | + TR_loggerLog(TR_logger, TR_LOGGER_DEBUG, | |
76 | + "[%s] - leave cond wait", | |
77 | + buffer); | |
78 | + event = NULL; | |
79 | + pthread_mutex_unlock(&(this->events_lock)); | |
71 | 80 | continue; |
81 | + } else { | |
82 | + this->events_handling++; | |
72 | 83 | } |
73 | 84 | |
85 | + pthread_mutex_unlock(&(this->events_lock)); | |
86 | + | |
74 | 87 | handler_queue_hv = TR_hashGetByVal( |
75 | 88 | this->handler, |
76 | 89 | TR_sdbm( |
... | ... | @@ -104,9 +117,12 @@ TR_eventDispatcherStart(TR_EventDispatcher this) |
104 | 117 | TR_delete(event); |
105 | 118 | } |
106 | 119 | |
107 | - if (pthread_equal(this->events_wait, pthread_self())) { | |
108 | - this->events_wait = FALSE; | |
120 | + pthread_mutex_lock(&(this->events_lock)); | |
121 | + this->events_handling--; | |
122 | + if (pthread_equal(this->events_poll, pthread_self())) { | |
123 | + this->events_poll = FALSE; | |
109 | 124 | } |
125 | + pthread_mutex_unlock(&(this->events_lock)); | |
110 | 126 | } |
111 | 127 | } |
112 | 128 | ... | ... |
... | ... | @@ -20,6 +20,8 @@ |
20 | 20 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
21 | 21 | */ |
22 | 22 | |
23 | +#define _GNU_SOURCE | |
24 | + | |
23 | 25 | #include <stdio.h> |
24 | 26 | |
25 | 27 | #include "trbase.h" |
... | ... | @@ -32,7 +34,7 @@ |
32 | 34 | TR_EventDone |
33 | 35 | TR_eventHandlerHandleEvent(TR_EventHandler this, TR_Event event) |
34 | 36 | { |
35 | - TR_EventDone retval; | |
37 | + char buffer[17]; | |
36 | 38 | TR_EventMethod_fptr event_func = NULL; |
37 | 39 | TR_HashValue handle_func_hv = TR_hashGetByVal( |
38 | 40 | TR_CLASSVARS(TR_EventHandler, TR_GET_CLASS(this))->event_methods, |
... | ... | @@ -44,17 +46,17 @@ TR_eventHandlerHandleEvent(TR_EventHandler this, TR_Event event) |
44 | 46 | |
45 | 47 | event_func = *(TR_EventMethod_fptr *)handle_func_hv->value; |
46 | 48 | |
47 | - retval = event_func(this, event); | |
49 | + pthread_getname_np(pthread_self(), buffer, 17); | |
48 | 50 | |
49 | 51 | TR_loggerLog(TR_logger, TR_LOGGER_DEBUG, |
50 | - "[%ld] - HANDLE(%zd): %s event on %p with no. %d", | |
51 | - pthread_self(), | |
52 | + "[%s] - HANDLE(%zd): %s event on %p with no. %d", | |
53 | + buffer, | |
52 | 54 | event->subject->emitted, |
53 | 55 | TR_getEventString(event), |
54 | 56 | event->subject, |
55 | 57 | event->serial); |
56 | 58 | |
57 | - return retval; | |
59 | + return event_func(this, event); | |
58 | 60 | } |
59 | 61 | |
60 | 62 | // vim: set ts=4 sw=4: | ... | ... |
... | ... | @@ -20,6 +20,8 @@ |
20 | 20 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
21 | 21 | */ |
22 | 22 | |
23 | +#define _GNU_SOURCE | |
24 | + | |
23 | 25 | #include <stdio.h> |
24 | 26 | #include <pthread.h> |
25 | 27 | |
... | ... | @@ -32,12 +34,15 @@ int |
32 | 34 | TR_eventHandlerIssueEvent(TR_EventHandler this, TR_Event event) |
33 | 35 | { |
34 | 36 | if (event) { |
35 | - int i; | |
37 | + int i; | |
38 | + char buffer[17]; | |
39 | + | |
40 | + pthread_getname_np(pthread_self(), buffer, 17); | |
36 | 41 | |
37 | 42 | for (i=0; i<this->ndispatcher; i++) { |
38 | 43 | TR_loggerLog(TR_logger, TR_LOGGER_DEBUG, |
39 | - "[%ld] - ISSUE(%zd): %s event on %p with no. %d", | |
40 | - pthread_self(), | |
44 | + "[%s] - ISSUE(%zd): %s event on %p with no. %d", | |
45 | + buffer, | |
41 | 46 | event->subject->emitted, |
42 | 47 | TR_getEventString(event), |
43 | 48 | event->subject, | ... | ... |
... | ... | @@ -27,8 +27,21 @@ |
27 | 27 | #include "tr/logger.h" |
28 | 28 | #include "trbase.h" |
29 | 29 | |
30 | -static int eventSubjectCtor(void * _this, va_list * params) { return 0; } | |
31 | -static void eventSubjectDtor(void * _this) {} | |
30 | +static | |
31 | +int | |
32 | +eventSubjectCtor(void * _this, va_list * params) | |
33 | +{ | |
34 | + pthread_mutex_init(&((TR_EventSubject)_this)->lock, NULL); | |
35 | + | |
36 | + return 0; | |
37 | +} | |
38 | + | |
39 | +static | |
40 | +void | |
41 | +eventSubjectDtor(void * _this) | |
42 | +{ | |
43 | + pthread_mutex_destroy(&((TR_EventSubject)_this)->lock); | |
44 | +} | |
32 | 45 | |
33 | 46 | TR_INIT_IFACE(TR_Class, eventSubjectCtor, eventSubjectDtor, NULL); |
34 | 47 | TR_CREATE_CLASS(TR_EventSubject, NULL, NULL, TR_IF(TR_Class)) = { | ... | ... |
... | ... | @@ -22,6 +22,7 @@ |
22 | 22 | |
23 | 23 | #include <stdio.h> |
24 | 24 | #include <stdint.h> |
25 | +#include <pthread.h> | |
25 | 26 | |
26 | 27 | #include "tr/event.h" |
27 | 28 | #include "tr/event_subject.h" |
... | ... | @@ -37,7 +38,9 @@ TR_eventSubjectEmit(TR_EventSubject this, int idx, void * data) |
37 | 38 | if (id && ! this->fin) { |
38 | 39 | event = TR_new(TR_Event, id, this); |
39 | 40 | TR_eventSetData(event, data); |
41 | + pthread_mutex_lock(&this->lock); | |
40 | 42 | this->emitted++; |
43 | + pthread_mutex_unlock(&this->lock); | |
41 | 44 | } |
42 | 45 | |
43 | 46 | return event; | ... | ... |
... | ... | @@ -31,9 +31,13 @@ static |
31 | 31 | int |
32 | 32 | eventThreadCtor(void * _this, va_list * params) |
33 | 33 | { |
34 | - TR_EventThread this = _this; | |
34 | + TR_EventThread this = _this; | |
35 | + char * name; | |
35 | 36 | |
36 | 37 | this->dispatcher = va_arg(*params, TR_EventDispatcher); |
38 | + name = va_arg(*params, char *); | |
39 | + | |
40 | + if (name) this->name = TR_strdup(name); | |
37 | 41 | |
38 | 42 | return 0; |
39 | 43 | } |
... | ... | @@ -48,6 +52,8 @@ eventThreadDtor(void * _this) |
48 | 52 | pthread_cancel(this->handle); |
49 | 53 | pthread_join(this->handle, NULL); |
50 | 54 | } |
55 | + | |
56 | + TR_MEM_FREE(this->name); | |
51 | 57 | } |
52 | 58 | |
53 | 59 | TR_INIT_IFACE(TR_Class, eventThreadCtor, eventThreadDtor, NULL); | ... | ... |
... | ... | @@ -20,6 +20,8 @@ |
20 | 20 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
21 | 21 | */ |
22 | 22 | |
23 | +#define _GNU_SOURCE | |
24 | + | |
23 | 25 | #include <pthread.h> |
24 | 26 | |
25 | 27 | #include "trbase.h" |
... | ... | @@ -32,6 +34,7 @@ void * |
32 | 34 | TR_eventStreadRun(void * message) |
33 | 35 | { |
34 | 36 | TR_EventThread this = message; |
37 | + if (this->name) pthread_setname_np(pthread_self(), this->name); | |
35 | 38 | TR_eventDispatcherStart(this->dispatcher); |
36 | 39 | return NULL; |
37 | 40 | } | ... | ... |
Please
register
or
login
to post a comment